Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java #194

Merged
merged 3 commits into from
May 28, 2024
Merged

Upgrade Java #194

merged 3 commits into from
May 28, 2024

Conversation

khatchad
Copy link
Collaborator

@khatchad khatchad commented May 2, 2024

Use Java 17.

Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will force any users of wala/ML to also be on Java 17. Are we ok with that?

@khatchad
Copy link
Collaborator Author

This will force any users of wala/ML to also be on Java 17. Are we ok with that?

Good question. Java 17 is an LTS release. Also, given that the release date is Sep 2021, I think that it's been enough time. But, we can continue with Java 11 (though the Maven build specifies Java 8) if desired.

@msridhar
Copy link
Member

Good question. Java 17 is an LTS release. Also, given that the release date is Sep 2021, I think that it's been enough time. But, we can continue with Java 11 (though the Maven build specifies Java 8) if desired.

I would personally be fine with Java 17. I doubt we have many users stuck on Java 8, and going from Java 11 to 17 shouldn't be as big a deal. For now, we can revert fairly easily if someone complains. Once we start adopting Java 17 language constructs reverting will be more difficult.

I'll leave the decision to you @khatchad

@khatchad khatchad merged commit b813bde into wala:master May 28, 2024
1 check passed
@khatchad khatchad deleted the contrib_upgrade_java branch May 28, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants